Why won't this function work as expected? List exactly one reason.
1 2 3 4 5 6 7 8 9 10 11 12 13 | def make_op_with_history(config): how = config[0] args = config[1:] if how.split()[0] == 'dot_from_papers': return [(how, make_op(config))] if how.split()[0] in ['const_add', 'const_mul']: return [(how, make_op(config))] + make_op_with_history(config[1]) out = [] for arg in args: hist = make_op_with_history(arg) out.append(hist) return [(how, make_op(config))] + out |
Why won't this function work as expected? List exactly one reason.
1 2 3 4 5 6 7 8 9 10 11 12 13 | def make_op_with_history(config): how = config[0] args = config[1:] if how.split()[0] == 'dot_from_papers': return [(how, make_op(config))] if how.split()[0] in ['const_add', 'const_mul']: return [(how, make_op(config))] + make_op_with_history(config[1]) out = [] for arg in args: hist = make_op_with_history(arg) out.append(hist) return [(how, make_op(config))] + out |
One reason this function won't work as expected is that it calls itself recursively without a base case. The recursive call `make_op_with_history(config[1])` and `make_op_with_history(arg)` will eventually lead to an `IndexError` when `config` or `arg` is empty, because it tries to access the first element of an empty list.
I asked a question about why some code was incorrect. The answer is "because because the code uses append instead of extend". Does this student answer say that? Giving multiple answers is okay as long as it also says somewhere that the code should replace the append with extend. One reason this function won't work as expected is that it calls itself recursively without a base case. The recursive call `make_op_with_history(config[1])` and `make_op_with_history(arg)` will eventually lead to an `IndexError` when `config` or `arg` is empty, because it tries to access the first element of an empty list. Answer either 'The student passes' or 'The student fails'.
The student fails.
Testing if the previous output contains the string student passes
: False